Open
Conversation
isuruf
reviewed
Jan 28, 2026
src/mathfuns.jl
Outdated
Comment on lines
192
to
193
| Base.Symbol(s::SymFunction) = Symbol(s.name) | ||
| Base.nameof(s::SymFunction) = Symbol(s) |
Contributor
Author
There was a problem hiding this comment.
I got cute? They could both resolve to Symbol(s.name). (I was looking for a generic that would give the symbol and not the general symbol for SymFunction and wasn't sure which should be preferred for generic programming.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small adjustments
added
constto several constant variablesallow
TermInterface.operationto work withSymFunctionobjectsadd
nameofmethod forSymFunctionobjectsConversion of :ℯ (\euler) (Fixes bug)
add
unwrap_constto mirror SymbolicUtils behaviour (no error)add
isevenandisodd; add tests (allocate due to conversion to Integer)adjust behavior of _convert for expressions (Really want to avoid this, but somehow writing
convert(Expr, x)and getting a symbol seems wrong. Add test for behaviour.