BridgeJS: Include properties and release() in declare global class stubs#693
Merged
krodak merged 2 commits intoswiftwasm:mainfrom Mar 5, 2026
Merged
Conversation
kateinoigakukun
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When
exposeToGlobal: trueis set inbridge-js.config.json, BridgeJS emits adeclare globalblock so TypeScript knows the exported Swift classes exist onglobalThis. These stubs were generated with constructor signatures and methods, but two things were always missing:@JS vardeclarations on the class)release(): void(inherited fromSwiftHeapObjectby every exported class)This meant that accessing an instance through the
globalThispath produced a TypeScript type with no properties and norelease(), forcing consumers to useas unknown as TheInterfacecasts to recover full typing.Before (
declare globalstub for a class with aprecisionproperty):After:
The fix is a small addition to
generateNamespaceDeclarationsForNodeinBridgeJSLink.swift: after emitting methods, emit non-static properties sorted by name, then always appendrelease(): void.Three snapshot files are updated:
Namespaces.Global.d.ts,EnumNamespace.Global.d.ts, andMixedModules.d.ts.