BridgeJS: fix codegen for async + throws exported methods#691
Merged
kateinoigakukun merged 1 commit intoswiftwasm:mainfrom Mar 4, 2026
Merged
Conversation
The render method handled isAsync and isThrows as mutually exclusive branches, so methods that were both async and throws only got the JSPromise.async wrapper without the explicit throws(JSException) type annotation on the closure. This caused the Swift compiler to infer throws(any Error) instead of throws(JSException), producing a build error. Add a new branch for the combined case that explicitly annotates the closure with `() async throws(JSException) [-> JSValue] in`. Made-with: Cursor
Member
kateinoigakukun
left a comment
kateinoigakukun
left a comment
There was a problem hiding this comment.
I'd like to overhaul async support using JSTypedClosure later anyway but let's fix this issue now
kateinoigakukun
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The render method handled
isAsyncandisThrowsas mutually exclusive branches, so methods that were both async and throws only got the JSPromise.async wrapper without the explicit throws(JSException) type annotation on the closure. This caused the Swift compiler to infer throws(any Error) instead of throws(JSException), producing a build error.Add a new branch for the combined case that explicitly annotates the closure with
() async throws(JSException) [-> JSValue] in.Made-with: Cursor by Ryan, pushed up and reviewed by me :-)