Skip to content

Add property access tracing to JSTracing#687

Merged
kateinoigakukun merged 5 commits intoswiftwasm:mainfrom
gn-adin-b:adin/property-access-tracing
Mar 3, 2026
Merged

Add property access tracing to JSTracing#687
kateinoigakukun merged 5 commits intoswiftwasm:mainfrom
gn-adin-b:adin/property-access-tracing

Conversation

@gn-adin-b
Copy link
Contributor

@gn-adin-b gn-adin-b commented Mar 3, 2026

Summary

  • Adds propertyGet/propertySet cases to JSCallInfo so property reads/writes on JSObject are traced
  • Instruments all 4 subscript pairs (String, JSString, Int, JSSymbol) with the beginJSCall/traceEnd pattern
  • Adds test for property access tracing and updates existing method test to filter by event type

Test plan

  • CI passes with --traits Tracing

@gn-adin-b
Copy link
Contributor Author

gn-adin-b commented Mar 3, 2026

cc @kateinoigakukun

kateinoigakukun
kateinoigakukun approved these changes Mar 3, 2026
View reviewed changes
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to JavaScriptKit :)

@kateinoigakukun kateinoigakukun merged commit 5529520 into swiftwasm:main Mar 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gn-adin-b @kateinoigakukun