jextract/jni: Refactor toString generation to use the standard method generation path#567
Merged
ktoso merged 4 commits intoswiftlang:mainfrom Feb 24, 2026
Merged
Conversation
madsodgaard
reviewed
Feb 17, 2026
Contributor
Author
|
I have addressed the feedback. Are there any remaining concerns ? |
ktoso
changed the title
toString generation to use the standard method generation pathtoString generation to use the standard method generation path
ktoso
reviewed
Feb 24, 2026
ktoso
approved these changes
Feb 24, 2026
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Looks fine now, thank you
ktoso
force-pushed
the
tostring_thunk
branch
from
5172a93 to
b338b20
Compare
Collaborator
|
Thank you! |
Contributor
Author
|
Thank you too! Happy to see this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the implementations for
toStringandtoDebugStringmethods are handled by dedicated, hardcoded logic.However, these methods are fundamentally identical to standard function calls in terms of their underlying mechanism.
This inconsistency makes it difficult to maintain parity with other parts of the generator. Specifically, as I work on implementing support for function calls in generic type, I find myself having to write redundant specialized logic just for
toString, which adds unnecessary complexity.Changes
Treat
toStringandtoDebugStringasImportedFunc.This allows them to be processed through the general method generation path.
Note
While this change also affects FFM mode, it will currently be ignored because
Stringreturn values are not yet supported in that mode.