perf(middleware): await background task cancellation on timeout#786
Open
ishaanxgupta wants to merge 1 commit intosupermemoryai:mainfrom
Open
perf(middleware): await background task cancellation on timeout#786ishaanxgupta wants to merge 1 commit intosupermemoryai:mainfrom
ishaanxgupta wants to merge 1 commit intosupermemoryai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added an await asyncio.gather(*tasks_to_cancel, return_exceptions=True) call inside the except asyncio.TimeoutError: block of wait_for_background_tasks
Previously, when the wait_for_background_tasks method timed out, it iterated over unfinished tasks and called task.cancel(). However, calling cancel() only requests cancellation; it doesn't wait for the task's cleanup logic (e.g., except asyncio.CancelledError:) to actually complete. This created orphaned tasks running asynchronously in the background.
Failing to await cancelled tasks leads to "Task was destroyed but it is pending!" errors at shutdown. More importantly, it leaks memory and limits scalability because background cleanup continues executing unbounded.