Skip to content

Clamp menu position to viewport #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caio-pizzol wants to merge 1 commit into from
Closed

Clamp menu position to viewport #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,26 @@ const resolveToolbar = (
};
};

const MENU_VIEWPORT_PADDING = 10;
const MENU_APPROX_WIDTH = 250;
const MENU_APPROX_HEIGHT = 300;

const clampToViewport = (rect: DOMRect): DOMRect => {
const maxLeft = window.innerWidth - MENU_APPROX_WIDTH - MENU_VIEWPORT_PADDING;
const maxTop =
window.innerHeight - MENU_APPROX_HEIGHT - MENU_VIEWPORT_PADDING;

const clampedLeft = Math.min(rect.left, maxLeft);
const clampedTop = Math.min(rect.top, maxTop);

return new DOMRect(
Math.max(clampedLeft, MENU_VIEWPORT_PADDING),
Math.max(clampedTop, MENU_VIEWPORT_PADDING),
rect.width,
rect.height,
);
};

const SuperDocTemplateBuilder = forwardRef<
Types.SuperDocTemplateBuilderHandle,
Types.SuperDocTemplateBuilderProps
Expand Down Expand Up @@ -385,7 +405,9 @@ const SuperDocTemplateBuilder = forwardRef<

if (text === trigger) {
const coords = e.view.coordsAtPos(from);
const bounds = new DOMRect(coords.left, coords.top, 0, 0);
const bounds = clampToViewport(
new DOMRect(coords.left, coords.top, 0, 0),
);

const cleanup = () => {
const editor = superdocRef.current?.activeEditor;
Expand Down Expand Up @@ -435,7 +457,9 @@ const SuperDocTemplateBuilder = forwardRef<
updateMenuFilter(queryText);

const coords = e.view.coordsAtPos(from);
const bounds = new DOMRect(coords.left, coords.top, 0, 0);
const bounds = clampToViewport(
new DOMRect(coords.left, coords.top, 0, 0),
);
setMenuPosition(bounds);
});

Expand Down
Loading