-
Notifications
You must be signed in to change notification settings - Fork 1
feat: enhance field management with grouping and improved UI #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
caio-pizzol
commented
Nov 21, 2025
- Introduced grouping functionality for fields in FieldList component.
- Added FieldItem component for better encapsulation of field rendering logic.
- Implemented expand/collapse feature for grouped fields.
- Enhanced styling for field items and group headers for better UX.
- Updated FieldMenu to support selection of existing fields with grouping.
- Modified TemplateField type to include group property for better organization.
- Improved overall code structure and readability.
- Introduced grouping functionality for fields in FieldList component. - Added FieldItem component for better encapsulation of field rendering logic. - Implemented expand/collapse feature for grouped fields. - Enhanced styling for field items and group headers for better UX. - Updated FieldMenu to support selection of existing fields with grouping. - Modified TemplateField type to include group property for better organization. - Improved overall code structure and readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
template-builder/src/index.tsx
Lines 58 to 62 in d805d9f
| if ( | |
| left.id !== right.id || | |
| left.alias !== right.alias || | |
| left.tag !== right.tag || | |
| left.position !== right.position || |
Template fields now carry a group value, but the equality helper still only compares id/alias/tag/position/mode. areTemplateFieldsEqual gates both discoverFields and delete logic, so if structured content helpers add or remove a group without changing those other attributes, the builder will treat the arrays as unchanged and skip setTemplateFields/onFieldsChange, leaving the FieldList in the wrong grouping. The comparison should also include group so grouping changes propagate.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🎉 This PR is included in version 0.2.0-next.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [0.3.0](v0.2.0...v0.3.0) (2025-11-21) ### Bug Fixes * add deduplication for React dependencies in Vite config and clean up package.json ([dc17f23](dc17f23)) * add missing deployment ID in GitHub Pages workflow ([e350b3b](e350b3b)) * update SuperDoc initialization with document mode and enhance Vite config external dependencies ([9e0989a](9e0989a)) ### Features * add getSuperDoc method for accessing SuperDoc API ([#18](#18)) ([ccda4e0](ccda4e0)) * enhance field management with grouping and improved UI ([#19](#19)) ([a64e8b8](a64e8b8))
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |