feat: namespace internal ui classes#3544
Merged
Merged
Conversation
superdoc-bot
Bot
added
review: careful
review: quick
and removed
review: careful
labels
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
artem-harbour
force-pushed
the
artem/namespace-classes
branch
3 times, most recently
from
d7a2fb2 to
37b75b2
Compare
artem-harbour
force-pushed
the
artem/namespace-classes
branch
from
37b75b2 to
25548b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements SD-2560 (and follow-up hardening) in small, focused steps to reduce CSS collisions with host apps and provide stable UI targeting hooks.
What changed
Renamed collision-prone internal classes to
sd-*:button-icon->sd-button-icontoolbar-item(+ compact modifiers) ->sd-toolbar-itembutton-label->sd-button-labeldropdown-caret->sd-dropdown-caretdisabled->sd-disabledis-disabled->sd-is-disabledAdded stable
data-sd-partanchors:toolbar,toolbar-item,editor-root,comment-threaddropdown-trigger(including toolbar dropdown)dropdown-menu(toolbar dropdown menu)Completed follow-up generic class hardening (second wave):
active/selected/error->sd-active/sd-selected/sd-errorrow/submit/submit-btn->sd-row/sd-submit/sd-submit-btnoption/option-row/option-item/option-state->sd-option*toolbar-button/toolbar-icon/visually-hidden->sd-toolbar-*/sd-visually-hiddentoolbar-item-ctn->sd-toolbar-item-ctnis-selected->sd-is-selectedExtended CSS bleed lint coverage