feat(solid): [WIP] Add wrapper implementation for SolidJS as @superdoc-dev/solid#3292
Draft
msviderok wants to merge 10 commits into
Draft
feat(solid): [WIP] Add wrapper implementation for SolidJS as @superdoc-dev/solid#3292msviderok wants to merge 10 commits into
@superdoc-dev/solid#3292msviderok wants to merge 10 commits into
Conversation
@superdoc-dev/solid@superdoc-dev/solid *[WIP]*
@superdoc-dev/solid *[WIP]*@superdoc-dev/solid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SolidJS wrapper package
@superdoc-dev/solid.This PR introduces a Solid-native
SuperDocEditorcomponent which is practically identical to@superdoc-dev/reactwith the only differences being the framework-specific lifecycle/state management parts.What Changed
packages/solidas a new workspace packageSuperDocEditorfor SolidJS.mdand config files to matchpackages/reactsuperdocconstructor configSuperDocEditor.test.tsxfrom `packages/react to keep the tests intact in terms of logic/behaviour/visual aspectsscripts/publish-solid.cjsfor publishing@superdoc-dev/solidWhat differs from
packages/reactReacttoSolid.mdfiles to adhere to Solid practicessrc/utils:shallowJsonEqualdue to fine-grained reactivity of Solid negating the need for the rest of React-specific onesshallowJsonEqualTesting
packages/solid/src/SuperDocEditor.test.tsxpnpm --filter @superdoc-dev/solid testSuperDocEditor.test.tsxtestsuite passes but with a post-error. Currently, I'm in progress resolving this issue, related to: discord conversation