Skip to content

chore: create measurement to layout ownership matrix#3158

Closed
VladaHarbour wants to merge 3 commits into
mainfrom
sd-2845_measurement-to-layout-matrix
Closed

chore: create measurement to layout ownership matrix#3158
VladaHarbour wants to merge 3 commits into
mainfrom
sd-2845_measurement-to-layout-matrix

Conversation

@VladaHarbour
Copy link
Copy Markdown
Contributor

This PR introduces measuring-layout-ownership.md document with Measuring → Layout ownership matrix and tests which lock current boundary.
@harbournick please let me know if it should live in the repo

@VladaHarbour VladaHarbour requested a review from harbournick May 5, 2026 14:14
@VladaHarbour VladaHarbour self-assigned this May 5, 2026
@VladaHarbour VladaHarbour requested a review from a team as a code owner May 5, 2026 14:14
@linear
Copy link
Copy Markdown

linear Bot commented May 5, 2026

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

caio-pizzol

This comment was marked as outdated.

@caio-pizzol caio-pizzol self-requested a review May 6, 2026 15:08
Copy link
Copy Markdown
Contributor

@caio-pizzol caio-pizzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

direction is right. three things inline.

Inline 1 - packages/layout-engine/docs/measuring-layout-ownership.md, line 1:

new docs/ folder - we keep layout-engine docs in CLAUDE.md and per-package READMEs today. could this go in CLAUDE.md instead? the follow-up list at the bottom feels like a Linear backlog.

Inline 2 - packages/layout-engine/layout-engine/src/measuring-layout-ownership-contracts.test.ts, lines 179-206:

the measuring test covers section breaks but this one only covers page and column breaks. could we add a section break case here too?

inline 3 - packages/layout-engine/layout-engine/src/measuring-layout-ownership-contracts.test.ts, lines 214-242:

this only passes because list layout isn't supported yet - when it lands, the test will start failing. could we use it.todo(...) so the next person updates it instead of deleting?

@VladaHarbour VladaHarbour force-pushed the sd-2845_measurement-to-layout-matrix branch from b28d284 to dbade84 Compare May 11, 2026 14:32
@VladaHarbour
Copy link
Copy Markdown
Contributor Author

direction is right. three things inline.

Inline 1 - packages/layout-engine/docs/measuring-layout-ownership.md, line 1:

new docs/ folder - we keep layout-engine docs in CLAUDE.md and per-package READMEs today. could this go in CLAUDE.md instead? the follow-up list at the bottom feels like a Linear backlog.

Inline 2 - packages/layout-engine/layout-engine/src/measuring-layout-ownership-contracts.test.ts, lines 179-206:

the measuring test covers section breaks but this one only covers page and column breaks. could we add a section break case here too?

inline 3 - packages/layout-engine/layout-engine/src/measuring-layout-ownership-contracts.test.ts, lines 214-242:

this only passes because list layout isn't supported yet - when it lands, the test will start failing. could we use it.todo(...) so the next person updates it instead of deleting?

Hi @caio-pizzol! Added some changes to address your comment

@VladaHarbour VladaHarbour force-pushed the sd-2845_measurement-to-layout-matrix branch from dbade84 to 4b0f7a1 Compare May 11, 2026 14:41
Copy link
Copy Markdown
Contributor

Thanks for working on this. I’m going to close this PR because it is now out of date with main.

The work is still useful, especially the two test files and the Measuring → Layout notes. But the docs structure changed since this PR was opened, so this now has conflicts and some wording is stale.

The clean path is to open a fresh PR from current main with:

  • the two test files
  • an updated packages/layout-engine/AGENTS.md section
  • no CLAUDE.md changes

Closing as stale, not because the idea is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants