fix(rendering): apply superscript/subscript font-size scaling during layout#2340
fix(rendering): apply superscript/subscript font-size scaling during layout#2340gpardhivvarma wants to merge 3 commits intosuperdoc-dev:mainfrom
Conversation
…layout The 65% font-size reduction for superscript/subscript was applied as a post-processing DOM patch, but text was measured at full size — causing oversized rendering. Move vertAlign and baselineShift into the TextRun contract so the layout engine measures at the correct scaled size, and the DOM painter applies vertical-align CSS directly.
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@gpardhivvarma solid approach — moving this into the rendering pipeline is the right call.
two things to fix in files not touched by the diff:
-
renderer.ts:6464—deriveBlockVersion()doesn't includevertAlignorbaselineShiftin the hash. switching between superscript and subscript won't visually update because both use the same scaled font size, so the hash stays identical and the DOM is reused. -
tracked-changes.ts:325—resetRunFormatting()doesn't clearvertAlignorbaselineShift. if someone adds superscript in a tracked change, "original" mode will still show it as superscript instead of the old formatting.
no tests added — would be good to cover the new scaling and CSS output in computeRunAttrs, applyTextStyleMark, and applyRunStyles.
left one inline comment.
- Extract 0.65 to SUBSCRIPT_SUPERSCRIPT_SCALE constant in constants.ts - Add vertAlign/baselineShift to deriveBlockVersion() hash for both paragraph and table runs so changes trigger DOM updates - Clear vertAlign/baselineShift in resetRunFormatting() for tracked changes original mode - Add tests for computeRunAttrs, applyTextStyleMark, and DOM painter vertical-align CSS rendering
|
@caio-pizzol please review this |
2 participants
Summary
PresentationEditor.#applyVertAlignToLayout(), but text was measured and laid out at full font size — causing oversized appearancevertAlignandbaselineShiftto theTextRuncontract (RunMarks) so the layout engine sees themcomputeRunAttrs()andapplyTextStyleMark()now extract vertAlign/position and apply the 0.65× font-size scale at conversion time, before measurementapplyRunStyles()rendersvertical-align: super/sub/baselineor customvertical-align: Xptdirectly#applyVertAlignToLayout()post-processing patch from PresentationEditorTest plan
pnpm test:layoutpnpm test— all unit tests pass (verified: 2,240 tests across pm-adapter + painter-dom)