refactor: remove redundant parameters in pm-adapter (SD-1587) #1823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 23, 2026 15:46
I ran a bunch of tests in Word and the behavior we were implementing was wrong. The properties from the Normal style are always after the document's defaults, regardless of the value of w:default for the Normal style. Also, the properties from the Normal style are only added to the chain if the element does not have a linked style assigned.
luccas-harbour
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aaed6b64de
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
harbournick
deleted the
luccas/sd-1587-refactor-pm-adapter-in-layout-engine-part-2
branch
harbournick
pushed a commit
that referenced
this pull request
Jan 24, 2026
* refactor: remove unused styleContext parameter * fix: extract default font and size from docDefaults * fix: adjust default font and size to match word * fix: ordering of document defaults and normal style I ran a bunch of tests in Word and the behavior we were implementing was wrong. The properties from the Normal style are always after the document's defaults, regardless of the value of w:default for the Normal style. Also, the properties from the Normal style are only added to the chain if the element does not have a linked style assigned. * test: fix existing tests * chore: remove unused imports * fix: interpret default font size as pixels instead of points --------- Co-authored-by: Luccas Correa <luccas@superdoc.dev>
harbournick
pushed a commit
that referenced
this pull request
Jan 24, 2026
# [1.9.0-next.2](v1.9.0-next.1...v1.9.0-next.2) (2026-01-24) ### Bug Fixes * remove redundant parameters in pm-adapter (SD-1587) ([#1823](#1823)) ([e315ad4](e315ad4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
styleContextparameter which was not being used. The converters get the numbering definitions and linked styles from theconverterContextso this parameter was not needed.docDefaultsif the document doesn't define them.defaultFontanddefaultSizeparameters that were passed to the converters were removed.docDefaultsand theNormalstyle's props fit into the style resolution chain was fixed so that it matches Word's behavior