Skip to content

Conversation

@luccas-harbour
Copy link
Contributor

@luccas-harbour luccas-harbour commented Jan 23, 2026

  • In the PR that took care of style resolution and list indentation, I implemented a new translator for the numbering.xml file and used the encoded data structure for resolving list indentation (editor.converter.translatedNumbering). The problem was that when a new list definition is created this new data structure was not being updated.
  • I haven't yet removed the old data structure (editor.converter.numbering) for compatibility but this should be addressed later
  • There is one unit test that's failing because of a missing docx file that was not commited to the repo

@linear
Copy link

linear bot commented Jan 23, 2026

@luccas-harbour luccas-harbour marked this pull request as ready for review January 23, 2026 12:30
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 713f2af94b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@luccas-harbour luccas-harbour force-pushed the luccas/sd-1594-bug-list-items-cant-be-indented branch from 713f2af to 41651d8 Compare January 23, 2026 12:55
Copy link
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick merged commit 3f84beb into main Jan 23, 2026
1 of 4 checks passed
@harbournick harbournick deleted the luccas/sd-1594-bug-list-items-cant-be-indented branch January 23, 2026 15:09
harbournick pushed a commit that referenced this pull request Jan 23, 2026
## [1.8.2-next.5](v1.8.2-next.4...v1.8.2-next.5) (2026-01-23)

### Bug Fixes

* issue indenting list items (SD-1594) ([#1816](#1816)) ([3f84beb](3f84beb))
@harbournick
Copy link
Collaborator

🎉 This PR is included in version 1.8.2-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

harbournick pushed a commit that referenced this pull request Jan 23, 2026
## [1.8.3](v1.8.2...v1.8.3) (2026-01-23)

### Bug Fixes

* add double click event for annotation ([#1803](#1803)) ([509c882](509c882))
* cursor delay when dragging over a document ([#1802](#1802)) ([58691f1](58691f1))
* handling absolute paths for relationships ([#1811](#1811)) ([8647358](8647358))
* header/footer double click to edit ([#1814](#1814)) ([b4041d5](b4041d5))
* issue indenting list items (SD-1594) ([#1816](#1816)) ([3f84beb](3f84beb))
* preserve original document namespace declarations during export ([#1812](#1812)) ([4a3da75](4a3da75))
* table background/width and marker color fixes ([#1795](#1795)) ([50fc3ad](50fc3ad))
* table indent ([#1794](#1794)) ([fb0563e](fb0563e))
@harbournick
Copy link
Collaborator

🎉 This PR is included in version 1.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants