feat: add public scroll to page method #1791
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da46d77d16
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const pageEl = getPageElementByIndex(this.#viewportHost, pageIndex); | ||
| if (pageEl) { | ||
| pageEl.scrollIntoView({ block: 'start', inline: 'nearest', behavior: scrollBehavior }); | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
This implementation only calls scrollIntoView if getPageElementByIndex returns an element, and otherwise returns false without changing scroll. When page virtualization is enabled, off‑screen pages are often not mounted in the DOM, so getPageElementByIndex will return null even for valid pages; in that case scrollToPage cannot bring the page into view at all. This makes the new public API fail for any page outside the mounted window. Consider using the same approach as other navigation helpers (e.g., scroll to the computed y‑position and/or wait for mount) so virtualized pages can be reached.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Implementing this fix
mattConnHarbour
force-pushed
the
SD-1542
branch
from
da46d77 to
76f836b
Compare
|
@harbournick this is ready for your review when you get a chance |
No description provided.