feat(comments): add anchor helpers #1775
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c8b2427e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!commentOrId) return null; | ||
| if (typeof commentOrId === 'object') { | ||
| return commentOrId.commentId ?? commentOrId.importedId ?? null; | ||
| } | ||
| return commentOrId; |
There was a problem hiding this comment.
When callers pass an importedId (which getComment accepts elsewhere in this store), getCommentPosition uses it directly as the lookup key. But comment positions are keyed by the threadId derived from commentId when present (see collectCommentPositions in packages/super-editor/src/core/presentation-editor/utils/CommentPositionCollection.ts), so imported comments where commentId != importedId (e.g., commentId: 'comment-1', importedId: 'import-1') will return null and getCommentAnchoredText/getCommentAnchorData won’t work for importedId inputs. Consider resolving IDs through getComment and then using comment.commentId ?? comment.importedId so importedId inputs still map to the stored positions.
Useful? React with 👍 / 👎.
1 participant
Adds helpers to read comment positions and anchored text without reimplementing selection logic.\n\nTests: pnpm -C packages/superdoc test -- comments-store.test.js