Skip to content

fix: resolve critical lodash vulnerabilities (transitive via gitbook-plugin-sharing) #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sumn2u merged 3 commits into from
Mar 9, 2026
Merged

fix: resolve critical lodash vulnerabilities (transitive via gitbook-plugin-sharing) #372

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ce93a3
fix: resolve critical lodash vulnerabilities in gitbook-plugin-sharing
mhughes2012 Mar 9, 2026
871e334
Update package.json
mhughes2012 Mar 9, 2026
dc62714
Update package.json
mhughes2012 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,13 @@
"commitizen": {
"path": "./node_modules/cz-conventional-changelog"
}
},
"overrides": {
"gitbook-plugin-sharing": {
"lodash": "4.17.21"
}
},
Comment on lines +40 to +44
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The npm overrides block here only forces lodash for gitbook-plugin-sharing. This repo also uses other GitBook/Honkit plugins that bring in vulnerable lodash versions (e.g., gitbook-plugin-exercises is documented as depending on lodash 3.x in the existing yarn install log), so npm audit may still report lodash advisories when installing with npm. Consider adding a root-level override for lodash (or additional per-plugin overrides) so all transitive lodash copies resolve to >=4.17.21, and re-run npm audit to confirm the advisories are fully cleared.

Copilot uses AI. Check for mistakes.
"resolutions": {
"lodash": "^4.17.21"
}
Comment on lines +40 to 47
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overrides (npm) and resolutions (Yarn) are both present, but they specify lodash differently (4.17.21 vs ^4.17.21) and the PR description says it forces ^4.17.21. To avoid inconsistent installs across package managers, align these constraints (either both exact or both ranged) and consider documenting/encoding the supported package manager + minimum npm version (since overrides requires newer npm).

Copilot uses AI. Check for mistakes.
}