Skip to content

DRAFT: feat(ui): float ui#371

Open
Dimfred wants to merge 1 commit intosudo-tee:mainfrom
Dimfred:feat/float-ui
Open

DRAFT: feat(ui): float ui#371
Dimfred wants to merge 1 commit intosudo-tee:mainfrom
Dimfred:feat/float-ui

Conversation

@Dimfred
Copy link
Copy Markdown

@Dimfred Dimfred commented May 5, 2026

Hi,
that's a vibed float ui, I'd refactor it before really submitting it.

Question for now would be, would you even want that? Cause if not, no need to refactor for me.

Also would be happy about any suggestion, how you'd like to have it / whether you already see some bugs.

Cheers

@jensenojs
Copy link
Copy Markdown
Contributor

jensenojs commented May 6, 2026

Can you simply tell us what the final effect looks like? Including

  • Effects that users can perceive
  • The scope of code refactoring changes and the expected shape

I previously wanted to create a feature, but I found that achieving an elegant implementation would require too much refactoring.

Additionally, in a series of small code refactorings we previously conducted, we found that several refactorings did not interact well with each other (although, as a hobby project, it's unrealistic to expect us to be overly serious). However, I still hope that, as much as possible, there will be potential for synergy in future refactoring directions. Perhaps at some point, the project's infrastructure will truly be refined enough to elegantly implement numerous features through composition.

Thank you in advance for your time!

@Dimfred
Copy link
Copy Markdown
Author

Dimfred commented May 6, 2026

Can you simply tell us what the final effect looks like? Including
Effects that users can perceive

The effect is simple instead of having a window left / right, you get a toggleable floating window:

image

The scope of code refactoring changes and the expected shape

Refactoring I mean more what I submitted, so I just wanted to say I'd like to clean it up and really check whether what I vibed fits the current codebase. I am pretty sure it can be simplified.

EDIT:
I am already seeing things which might be related to my patch, i.e. action selection disappearing sometimes, while I am on another tab. So things are still buggy I have to play around here more.

@sudo-tee
Copy link
Copy Markdown
Owner

sudo-tee commented May 6, 2026

Interesting,

We had a floating UI in the past that we inherited from goose.nvim (original forked repo). But it was not a "popup" style floating rather a floating panel, and the navigation was cumbersome so I removed it.

But having a floating window like a popup make sense.

I will review the code ans see how we can adapt it.

Thanks for the PR

@Dimfred
Copy link
Copy Markdown
Author

Dimfred commented May 6, 2026

Just let me know once you know how you'd like to have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants