feat: improve DECIMAL type handling #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
asolimando
force-pushed
the
main-issue_655_decimal_type
branch
from
27de37b to
a21deb8
Compare
bestbeforetoday
changed the title
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday and
vbarua
nielspardon
approved these changes
Jan 5, 2026
Member
nielspardon
left a comment
nielspardon
left a comment
There was a problem hiding this comment.
LGTM, thanks for improving this
mbwhite
pushed a commit
to mbwhite/substrait-java
that referenced
this pull request
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explicit DECIMAL type handling in
SubstraitTypeSystemto ensure maximum precision and scale of 38, consistent with the Substrait specification.Substrait specifies DECIMAL max precision/scale as 38, while Calcite's default is 19. Previously relied on deprecated methods
getMaxNumericPrecision()andgetMaxNumericScale()(deprecated in Calcite 1.38.0, will be made final in 1.42.0).This change migrates to the new API pattern using
getMaxPrecision(SqlTypeName)andgetMaxScale(SqlTypeName).Fixes #655