ci: enforce commitlint only on PR titles and descriptions #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
commented
Dec 17, 2025
| @@ -0,0 +1,63 @@ | |||
| name: PR Title Check | |||
Member
Author
There was a problem hiding this comment.
This was copied wholesale from https://github.com/substrait-io/substrait/blob/d1045ad1c080ecc06ea0515a8396644023bda8aa/.github/workflows/pr_breaking.yml
Member
Author
|
Addresses #640 |
mbwhite
approved these changes
Dec 18, 2025
benbellick
approved these changes
Dec 19, 2025
| issue_number: context.issue.number, | ||
| body: message | ||
| }) | ||
| core.setFailed(message) |
Member
There was a problem hiding this comment.
I wonder if we could make this action simpler by not commenting on the PR? And instead just have the CI/CD check fail? I'm not so particular, this just seems simpler and easier to maintain that way 🤷
Member
Author
There was a problem hiding this comment.
I'm going to leave the comment for now, as it includes links to the conventional commit standard, which helps users understand what the requirements are explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we squash merge in this repository, checking that individual commit message
follow the Conventional Commits spec is not useful.
Instead, enforce that the PR title and description do follow the specification,
as that does end up in the final commit.