Generic binary search #186
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the rest to crates/assignments
It should still be filled to parse correctly
Make dial_sender unbounded in stream behaviour
This library is imported in a different way in libp2p causing conflicts
Send random noise to anyone who opens the stream
There was a problem hiding this comment.
Pull request overview
This PR refactors the binary search implementation into a generic function and adds timestamp-based chunk lookup functionality.
- Introduced a generic
binary_search_byfunction with anIndexGettrait abstraction to enable binary search on different collection types - Added
find_chunk_by_timestampmethod to locate chunks by their last block timestamp - Updated test data and added comprehensive test coverage for the new timestamp-based search functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
crates/assignments/src/reader.rs |
Refactored inline binary search into generic binary_search_by function; added IndexGet trait and Chunks wrapper; implemented find_chunk_by_timestamp method; added comprehensive unit tests |
crates/assignments/tests/test_reading.rs |
Added test cases for find_chunk_by_timestamp covering error conditions and various timestamp queries |
crates/assignments/tests/test_building.rs |
Updated test data to include last_block_timestamp for chunk2 |
crates/assignments/tests/assignment.fb |
Binary test data file updated to reflect schema changes (Git LFS pointer) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kalabukdima
approved these changes
Dec 9, 2025
toschoosqd
force-pushed
the
generic-binary-search
branch
from
c960dbd to
11f1796
Compare
Move the rest to crates/assignments
Make dial_sender unbounded in stream behaviour
This library is imported in a different way in libp2p causing conflicts
Make dial_sender unbounded in stream behaviour
This library is imported in a different way in libp2p causing conflicts
toschoosqd
force-pushed
the
generic-binary-search
branch
from
11f1796 to
7b112d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.