-
Notifications
You must be signed in to change notification settings - Fork 911
fix(SU2_PY): Fix Custom Objective Function for Unsteady Adjoint #2663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shbhmexe
wants to merge
12
commits into
su2code:develop
Choose a base branch
from
shbhmexe:verify-pr-2587-clean
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+668
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased fix from PR su2code#2587 with additional compatibility patch. Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Add CUSTOM_OBJFUNC output field support for shape_optimization.py. Fix updateHistoryMap.py parsing for field types without :: separator. Rebased from PR su2code#2587 (ErcanUmut60). Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
pcarruscag
reviewed
Dec 28, 2025
Run updateHistoryMap.py to regenerate historyMap.py. Fix script to handle HistoryFieldType passed as variable (without ::). Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defining Custom Objective Function does not work with
shape_optimization.py. ThehistoryMap.pyis updated in order to fix the problem.This PR is a rebased and fixed version of #2587 (original author: @ErcanUmut60), which was approved but stalled due to merge permissions.
Additional Fix: The
updateHistoryMap.pyscript has been updated to handle cases whereHistoryFieldTypeis passed as a variable (without::separator), preventing script crashes on some existing files indevelop.Proposed Changes
Files Modified:
SU2_CFD/src/output/CFlowOutput.cppSU2_PY/updateHistoryMap.py::separatordevelopbranchSU2_PY/SU2/io/historyMap.pyChecklist
pre-commit run --allto format old commits.Related Issues/PRs
Testing
updateHistoryMap.pyruns successfullyhistoryMap.pymatches expected output