Fix enthalpy related issues #2652
Open
+235
−210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigfooted
changed the title
bigfooted
changed the title
bigfooted
changed the title
Co-authored-by: Cristopher Morales <98025159+Cristopher-Morales@users.noreply.github.com>
…into fix_restart_scalars
bigfooted
commented
Dec 22, 2025
bigfooted
commented
Dec 22, 2025
bigfooted
changed the title
…into fix_restart_scalars
5 tasks
bigfooted
changed the title
bigfooted
changed the title
bigfooted
changed the title
pcarruscag
reviewed
Dec 29, 2025
Comment on lines
61
to
64
| const su2double t_ref = config->GetStandard_RefTemperatureND(); | ||
| Enthalpy_Ref = 0.0; | ||
| su2double t_i = 1.0; | ||
| for (int i = 0; i < N; ++i) { | ||
| t_i *= t_ref; | ||
| t_i *= STD_REF_TEMP; |
Member
There was a problem hiding this comment.
How does non-dimensionalization work here?
pcarruscag
approved these changes
Dec 29, 2025
pcarruscag
reviewed
Dec 29, 2025
| su2double t_i = 1.0; | ||
| for (int i = 0; i < N; ++i) { | ||
| t_i *= STD_REF_TEMP; | ||
| t_i *= STD_REF_TEMP / config->GetInc_Temperature_Ref(); |
Member
There was a problem hiding this comment.
Having a std_ref_temp_nd in CConfig probably makes sense if this will be used a lot
Contributor
Author
There was a problem hiding this comment.
we already have a temperature_ref and a temperature_init, I think we should re-use that.
pcarruscag
reviewed
Dec 29, 2025
| Note Cp = Cv, (gamma = 1).*/ | ||
| Temperature = t; | ||
| Enthalpy = Cp * Temperature; | ||
| Enthalpy = Cp * (Temperature - STD_REF_TEMP); // Sensible enthalpy relative to STD_REF_TEMP |
Member
There was a problem hiding this comment.
What about here? Is it always dimensional?
Contributor
Author
There was a problem hiding this comment.
It looks like it. I'll introduce Temperature_Ref for enthalpy nondimensionalization upstream of this..
bigfooted
commented
Dec 29, 2025
…into fix_restart_scalars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related Work
small fixes for #2426
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.