Skip to content

Fix wall distance computation for points on viscous wall #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rois1995 merged 18 commits into from
Mar 27, 2025
Merged

Fix wall distance computation for points on viscous wall #2484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a2b3693
- Fix Normal Distance bug
Mar 26, 2025
d882e5d
- pre-commit fixes
Mar 26, 2025
0140f2f
- correct compilation error
Mar 26, 2025
5f9cd9c
- Fix compilation error
Mar 26, 2025
c40f17b
- fix compilation error
Mar 26, 2025
83e7e7f
- revert changes
Mar 26, 2025
2fb60aa
- Update regression cases
Mar 26, 2025
1df8313
- change test cases branch
Mar 26, 2025
dc65cd8
- revert changes and put fix in the NearestNeighborDistance
Mar 26, 2025
bca0284
- test case branches
Mar 26, 2025
fb48919
- small fix to vandv
Mar 26, 2025
6276ce3
Update Common/include/geometry/CGeometry.hpp
bigfooted Mar 26, 2025
c5ef3ff
Update Common/include/geometry/CPhysicalGeometry.hpp
bigfooted Mar 26, 2025
23de022
- fix VAndV
Mar 26, 2025
6218a70
Merge remote-tracking branch 'origin/develop' into fix_NormalNeighbor…
Mar 27, 2025
15e2c83
- Fix MLPCpp
Mar 27, 2025
782fa90
Fix MLPCpp
Mar 27, 2025
f2bbf42
- Fix regression branch
Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Common/src/geometry/CGeometry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4074,7 +4074,8 @@ su2double NearestNeighborDistance(CGeometry* geometry, const CConfig* config, co
const su2double max = std::numeric_limits<su2double>::max();
su2double distance = max;
for (const auto jPoint : geometry->nodes->GetPoints(iPoint)) {
const su2double dist = geometry->nodes->GetWall_Distance(jPoint);
const su2double dist =
geometry->nodes->GetViscousBoundary(jPoint) ? 0.0 : geometry->nodes->GetWall_Distance(jPoint);
if (dist > EPS) distance = fmin(distance, dist);
}
if (distance > 0 && distance < max) return distance;
Expand Down
4 changes: 2 additions & 2 deletions TestCases/parallel_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,15 +397,15 @@ def main():
turb_flatplate_CC_Wilcox.cfg_dir = "rans/flatplate"
turb_flatplate_CC_Wilcox.cfg_file = "turb_SST_flatplate_compressibility_Wilcox.cfg"
turb_flatplate_CC_Wilcox.test_iter = 20
turb_flatplate_CC_Wilcox.test_vals = [-1.280875, 1.974210, 1.440441, 5.038396, -3.791318, 11.809748]
turb_flatplate_CC_Wilcox.test_vals = [-1.280875, 1.974210, 1.440441, 5.038396, -3.791093, 8.297424]
test_list.append(turb_flatplate_CC_Wilcox)

# Flat plate SST compressibility correction Sarkar
turb_flatplate_CC_Sarkar = TestCase('turb_flatplate_CC_Sarkar')
turb_flatplate_CC_Sarkar.cfg_dir = "rans/flatplate"
turb_flatplate_CC_Sarkar.cfg_file = "turb_SST_flatplate_compressibility_Sarkar.cfg"
turb_flatplate_CC_Sarkar.test_iter = 20
turb_flatplate_CC_Sarkar.test_vals = [-1.280875, 1.974210, 1.440441, 5.038396, -3.791321, 11.809748]
turb_flatplate_CC_Sarkar.test_vals = [-1.280875, 1.974210, 1.440441, 5.038396, -3.791096, 8.297424]
test_list.append(turb_flatplate_CC_Sarkar)

# ONERA M6 Wing
Expand Down
4 changes: 2 additions & 2 deletions TestCases/tutorials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def main():
tutorial_trans_flatplate_T3A.cfg_dir = "../Tutorials/compressible_flow/Transitional_Flat_Plate/Langtry_and_Menter/T3A"
tutorial_trans_flatplate_T3A.cfg_file = "transitional_LM_model_ConfigFile.cfg"
tutorial_trans_flatplate_T3A.test_iter = 20
tutorial_trans_flatplate_T3A.test_vals = [-5.841218, -2.094611, -3.947011, -0.305590, -1.586230, 8.296809, -3.507308, 0.394898]
tutorial_trans_flatplate_T3A.test_vals = [-5.837370, -2.092243, -3.983811, -0.302357, -1.937550, 1.768072, -3.496905, 0.391385]
tutorial_trans_flatplate_T3A.test_vals_aarch64 = [-5.837368, -2.092246, -3.984172, -0.302357, -1.928108, 1.667157, -3.496279, 0.391610]
tutorial_trans_flatplate_T3A.no_restart = True
test_list.append(tutorial_trans_flatplate_T3A)
Expand All @@ -246,7 +246,7 @@ def main():
tutorial_trans_flatplate_T3Am.cfg_dir = "../Tutorials/compressible_flow/Transitional_Flat_Plate/Langtry_and_Menter/T3A-"
tutorial_trans_flatplate_T3Am.cfg_file = "transitional_LM_model_ConfigFile.cfg"
tutorial_trans_flatplate_T3Am.test_iter = 20
tutorial_trans_flatplate_T3Am.test_vals = [-6.206421, -2.029271, -4.028227, -0.685277, -3.893712, 6.692342, -2.521007, 0.948646]
tutorial_trans_flatplate_T3Am.test_vals = [-6.063710, -1.945074, -3.946905, -0.549154, -3.863803, 2.662907, -2.517658, 1.112973]
tutorial_trans_flatplate_T3Am.test_vals_aarch64 = [-6.063726, -1.945088, -3.946923, -0.549166, -3.863794, 2.664439, -2.517601, 1.112978]
tutorial_trans_flatplate_T3Am.no_restart = True
test_list.append(tutorial_trans_flatplate_T3Am)
Expand Down
4 changes: 2 additions & 2 deletions TestCases/vandv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ def main():
bump_sst1994m.cfg_dir = "vandv/rans/bump_in_channel"
bump_sst1994m.cfg_file = "turb_bump_sst.cfg"
bump_sst1994m.test_iter = 5
bump_sst1994m.test_vals = [-13.006002, -10.671005, -10.602936, -7.625336, -10.992230, -0.224690, 0.004900]
bump_sst1994m.test_vals_aarch64 = [-13.006002, -10.671005, -10.602936, -7.625336, -10.992230, -0.224690, 0.004900]
bump_sst1994m.test_vals = [-13.025265, -10.669816, -10.615338, -7.577125, -10.709448, -5.453868, 0.004903]
bump_sst1994m.test_vals_aarch64 = [-13.025265, -10.669816, -10.615338, -7.577125, -10.709448, -5.453868, 0.004903]
test_list.append(bump_sst1994m)

# SWBLI SA
Expand Down