Skip to content

feat(eslint-config-react-native): enforce minimum id length #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pchalupa wants to merge 2 commits into
base: master
Choose a base branch
from
+37 −19
Open

feat(eslint-config-react-native): enforce minimum id length #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90088d0
feat(eslint-config-react-native): enforce minimum id length
pchalupa May 19, 2026
85abec3
chore: update package lock
pchalupa May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 14 additions & 8 deletions packages/eslint-config-react-native/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ const ignores = globalIgnores(['.expo/', 'expo-env.d.ts'])
const common = {
name: '@strv/eslint-config-react-native',
rules: {
// Enforce minimum identifier length to improve code readability, see https://eslint.org/docs/latest/rules/id-length
'id-length': ['error', { min: 2, exceptions: ['i', 't', 'b', '_', 'x', 'y', 'z'] }],

// Very expensive check, see https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/namespace.md
'import/namespace': 'off',
// Very expensive check, see https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-duplicates.md
Expand All @@ -19,6 +22,7 @@ const common = {
'import/no-named-as-default': 'off',
// https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-named-as-default-member.md
'import/no-named-as-default-member': 'off',

// Handled by TypeScript. Enable noUnusedLocals in your tsconfig.json, see https://www.typescriptlang.org/tsconfig/#noUnusedLocals
// https://eslint.org/docs/latest/rules/no-unused-vars
'no-unused-vars': 'off',
Expand All @@ -39,6 +43,8 @@ const react = {
shorthandLast: true,
},
],
// Only relevant in class components, see https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-direct-mutation-state.md
'react/no-direct-mutation-state': 'off',
// DisplayName is not required for React Native components, see https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/display-name.md
'react/display-name': 'off',
},
Expand All @@ -50,6 +56,14 @@ const typescript = defineConfig([
{
files: ['**/*.ts', '**/*.tsx'],
rules: {
// Enforce consistent type imports with inline style, see https://typescript-eslint.io/rules/consistent-type-imports/
'@typescript-eslint/consistent-type-imports': [
'error',
{ prefer: 'type-imports', fixStyle: 'inline-type-imports' },
],
// Allow throwing non-Error objects, but only Promises are allowed in React codebases, see https://typescript-eslint.io/rules/only-throw-error/
'@typescript-eslint/only-throw-error': ['error', { allow: ['Promise'] }],

// Handled by TypeScript. Enable noUnusedLocals in your tsconfig.json, see https://www.typescriptlang.org/tsconfig/#noUnusedLocals
// https://typescript-eslint.io/rules/no-unused-vars/
'@typescript-eslint/no-unused-vars': 'off',
Expand All @@ -73,14 +87,6 @@ const typescript = defineConfig([
'@typescript-eslint/unbound-method': 'off',
// Allows member access on any typed values, see https://typescript-eslint.io/rules/no-unsafe-member-access/
'@typescript-eslint/no-unsafe-member-access': 'off',

// Enforce consistent type imports with inline style, see https://typescript-eslint.io/rules/consistent-type-imports/
'@typescript-eslint/consistent-type-imports': [
'error',
{ prefer: 'type-imports', fixStyle: 'inline-type-imports' },
],
// Allow throwing non-Error objects, but only Promises are allowed in React codebases, see https://typescript-eslint.io/rules/only-throw-error/
'@typescript-eslint/only-throw-error': ['error', { allow: ['Promise'] }],
},
},
])
Expand Down
Loading