Optional cog "simplewriter" that enforces xkcd's simple writer in a text channel#367
Open
JoshuaS3 wants to merge 19 commits intostrinking:masterfrom
Open
Optional cog "simplewriter" that enforces xkcd's simple writer in a text channel#367JoshuaS3 wants to merge 19 commits intostrinking:masterfrom
JoshuaS3 wants to merge 19 commits intostrinking:masterfrom
Conversation
Direct copy of XKCD's simplewriter list
pylint warns about too many lines in core_words_list.py. I'd compact the list to use less lines, but black automatically re-expands it.
Contributor
Author
|
should be my last commit on this branch |
Contributor
Author
|
I lied |
emmiegit
reviewed
Aug 1, 2020
| __all__ = ["core_words_list"] | ||
|
|
||
| core_words_list = [] | ||
| core_words_list_path = os.path.join(os.path.dirname(__file__), "core_words_list.txt") |
Collaborator
There was a problem hiding this comment.
You can't always expect this directory to be writeable, it might be in /usr or something. Just have a line in the config instead.
Contributor
Author
There was a problem hiding this comment.
This is for a read operation of a text file in the same directory as this source file. The text file will not change and is not configurable through means other than a commit due to the static nature of the source.
Instead of making them partials
|
This is a fantastic idea, but unfortunately the code appears to be written in Python, which is out of line with our policy. Please revise and submit a new PR. I am immeasurably disappointed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When turned on and given a place to work in, this extra bit removes everything not found in the top ten hundred words and their other forms. This works the same as xkcd's simple writer.
When some not allowed words are put up or changed, that message is quickly removed from the place and this extra bit sends a message to the person who wrote it saying something like this:
This should lead to some pretty fun and interesting conversations.