Conversation
7b72320 to
03f94a4
Compare
| /// Returns path of Launcher (we can't use Assembly.GetEntryAssembly().Location in .NET Core, especially with self-publish). | ||
| /// </summary> | ||
| /// <returns></returns> | ||
| internal static string? GetExecutablePath() => Environment.ProcessPath; |
There was a problem hiding this comment.
nitpick: Could this property not be used directly?
There was a problem hiding this comment.
I think I just replaced code from the previous implementation to make it cross-platform without changing the overall structure. We could inline it manually.
On the other hand, the method name is a bit more explicit. It's likely inlined anyway by the compiler, so it's just a matter of preference.
| } | ||
|
|
||
| // Avalonia configuration, don't remove; also used by visual designer. | ||
| public static AppBuilder BuildAvaloniaApp() |
There was a problem hiding this comment.
nitpick: This method seems to be unused. It would be great to integrate with RunNewApp somehow
There was a problem hiding this comment.
It's used by the Avalonia plugin. It's needed for the designer.
03f94a4 to
e96d938
Compare
|
@Jklawreszuk I have merged back master to this PR's branch. It's mostly working but it would be nice to also support (un-)installing the Stride packages on Linux even if we can't fully use it there yet. Did you want to contribute to it? The branch is on this repo, so feel free to push commits if you want. |
|
I am sorry, but it took some time to review all the files.Overall, it looks great! A quite accurate implementation of the original Launcher. However, I have a few comments:
Other than that I didnt notice nothing unusual 😅 |
|
@Kryptos-FR Once the changes have been merged, I will try to adapt Launcher to Linux if necessary. But I think that installing/uninstalling packages works correctly, no? |
|
I don't remember if it does work. I assume since it's restoring packages it should. I guess we'll know soon. |
e96d938 to
e161999
Compare
ab329f3 to
482bd28
Compare
Use MarkView.Avalonia library for markdown
e161999 to
4950387
Compare
|
@Kryptos-FR Have you tested it on Windows? It seems to work fine on Linux. They only issue I see is the empty button in the release notes page |
Complete the launcher README with build, versioning and layout notes, and add a hub-and-spoke documentation set under docs/launcher/ covering architecture, view models, views, version management, self-update, settings, localization, packaging, lifecycle and cross-platform notes.
Captures the full delta between the current Avalonia branch and the WPF launcher on master — including silent regressions that are not marked with TODO/FIXME — and a phased roadmap to close the gap for cross-platform parity. Notes Stride.Metrics and PrivacyPolicyHelper as deliberate, permanent removals.
…ncher port roadmap Adds a test-infrastructure phase covering bootstrap of Stride.Launcher.Tests, view-model and Avalonia-headless integration tests, and CI wiring for both Windows and Linux.
…rsistence proposal
309b8af to
73d9945
Compare
|
@Jklawreszuk I have also tested on Linux. I fixed a few minors issues, though the phantom button remains. There are now a few docmentation files about the launcher. If you can review them, that would be nice. One of the document is a tracker for this current porting effort and will be removed once all tasks are completed. |
| - name: Build | ||
| run: | | ||
| dotnet build build\Stride.Launcher.sln ` | ||
| -m:1 -nr:false ` |
There was a problem hiding this comment.
note: remove this since default in now parallel builds on master (#3133).
… versioning scheme
…wn ViewModelBase Copies the ViewModelBase implementation from Stride.Core.Presentation (minus IDestroyable/IViewModelServiceProvider) so the runner has no external MVVM dependency. Renames SetProperty → SetValue to match Stride's API.

PR Details
New Launcher using Avalonia instead of WPF. Still needs some love.
Related Issue
#1503
Types of changes
Checklist