fix: avoid logging database password and username #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Database Password leak in logs
When the sink connects to the database, it prints the full DSN including the password.
{"logger":"sink-sql.postgres","message":"connecting to db","dsn":"... password=... ", "logging.googleapis.com/labels":{}}This exposes sensitive credentials in logs and can lead to a security breach.
This update logs non sensitive connection parameters only.