fix: refactor encoder to use CSV writer for row formatting #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you add a quick CHANGELOG entry line, ready to merge afterward. |
0xArdi
force-pushed
the
fix/use-encoder
branch
from
a052166 to
3fc8935
Compare
maoueh
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 CSV Encoding Fix
The previous implementation manually joined map values with commas:
This approach produced invalid CSV output when any value contained commas, quotes, or newlines — for example,
Michael Taolor ⚡️ (τ , τ)would break the format because the comma inside the parentheses was interpreted as a field separator.This update replaces the manual string join with Go’s standard
encoding/csvpackage, which properly escapes and quotes values according to [RFC 4180](https://www.rfc-editor.org/rfc/rfc4180). It also ensures consistent key order by sorting map keys before encoding.