Conversation
There was a problem hiding this comment.
Pull request overview
This pull request addresses Storybook build failures by adding OpenSSL legacy provider support, transpiling the react-draggable dependency, and adding Babel plugins to handle modern JavaScript syntax (optional chaining and nullish coalescing operators).
Changes:
- Added NODE_OPTIONS=--openssl-legacy-provider flag to Storybook scripts for Node.js 17+ compatibility
- Added Babel transform plugins for optional chaining and nullish coalescing operators to handle modern syntax in dependencies
- Configured webpack to transpile react-draggable package with Babel to resolve syntax compatibility issues
- Pinned react-draggable to version 4.4.5 using yarn resolutions
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Added OpenSSL legacy provider to storybook scripts, added Babel transform plugins as devDependencies, and pinned react-draggable version |
| babel.config.js | Added plugins array with optional chaining and nullish coalescing transforms |
| .storybook/webpack.config.js | Added webpack rule to transpile react-draggable with Babel to handle modern syntax |
| .storybook/addons.js | Removed addon-knobs registration import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,3 @@ | |||
| import '@storybook/addon-knobs/register'; | |||
| import '@storybook/addon-options/register'; | |||
There was a problem hiding this comment.
The import for '@storybook/addon-knobs/register' is being removed, but this addon is still actively used in multiple story files (useAsync.story.tsx, useAsyncRetry.story.tsx, createBreakpoint.story.tsx, useEnsuredForwardedRef.story.tsx, useKeyboardJs.story.tsx, useLogger.story.tsx, useMouseHovered.story.tsx). Removing this registration will cause these stories to fail as the knobs functionality will not be available. Either keep this import or remove all usage of addon-knobs from the stories.
| import '@storybook/addon-options/register'; | |
| import '@storybook/addon-options/register'; | |
| import '@storybook/addon-knobs/register'; |
No description provided.