Rewrite useSet and useMap to avoid building a new instance on each update#2687
Open
wahab-cide wants to merge 4 commits intostreamich:masterfrom
Open
Rewrite useSet and useMap to avoid building a new instance on each update#2687wahab-cide wants to merge 4 commits intostreamich:masterfrom
wahab-cide wants to merge 4 commits intostreamich:masterfrom
Conversation
Replace O(n) array conversions in useSet with native Set operations (add, delete) to improve complexity to O(1). Refactor useMap to use ref-based state. Both hooks now use useRef with counter-based re-rendering and maintain full API compatibility. Fixes streamich#1188
- Add comment explaining Object.is usage for NaN handling in useMap - Add comment explaining utils memoization for stable references - Apply prettier formatting fixes All tests passing (26/26), lint clean, types clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes
useSetanduseMaphooks to avoid inefficient array/object conversions on every operation. Addresses issue #1188.Problem
The original implementations had performance issues:
useSet
new Set([...Array.from(prevSet), item])- O(n) array conversion for O(1) Set operationsuseMap
Solution
Refactored both hooks to use immutable state updates with smart optimizations:
Early returns - Skip re-renders when operations don't change data
Proper memoization - Utils object stability for React.memo compatibility
Dependency fixes -
initialSet/initialMapproperly tracked for reset()Robustness improvements:
Object.isinstead of===for correct NaN handlingPerformance Impact
Breaking Changes
None. This is a performance optimization with full backward compatibility:
Type of change
Checklist
yarn test)yarn lint). Fix it withyarn lint:fixin case of failure.yarn lint:types).Test Results
Related Issues
Fixes #1188