fix(useLocalStorage): fix setter function returns incorrect previous value#2640
Open
kpCoder2801 wants to merge 1 commit intostreamich:masterfrom
Open
fix(useLocalStorage): fix setter function returns incorrect previous value#2640kpCoder2801 wants to merge 1 commit intostreamich:masterfrom
kpCoder2801 wants to merge 1 commit intostreamich:masterfrom
Conversation
|
Can somebody merge this, please! |
|
Yes please merge this asap 😄 ! |
|
Without this useLocalStorage becomes highly unusable. Bumping for visibility -- would love if this could get merged. I don't see any activity on the repo since December 2024, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the
useLocalStoragehook where thesetValuefunction does not return the correct previous value. The issue occurs because the setter function is wrapped in auseCallback, but the current state value was not included in the dependency array. As a result, the stale value was being captured and returned incorrectly.This fix adds the missing dependency to ensure the latest state is used in the callback.
Type of change
Checklist
yarn test)yarn lint). Fix it withyarn lint:fixin case of failure.yarn lint:types).Closes #2560