CoreOp: table-driven name lookup for all OpKind types#942
Merged
aqjune-aws merged 2 commits intomainfrom Apr 16, 2026
Merged
Conversation
Each OpKind type now defines a single `names : List (OpKind × String)` as the source of truth. Both `toString` and `ofString?` are derived from this list via `lookupName`/`lookupKind` helpers that use `List.find?`, which reduces in the kernel. This eliminates the sync problem: adding a new constructor without adding it to `names` causes the round-trip `decide` proof to fail at compile time. There is only one place to update per new variant. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Core operator kind ↔ string conversion to be table-driven: each OpKind defines a single names : List (OpKind × String) and both toString and ofString? are derived from it using shared lookup helpers, with round-trip properties proved via decide.
Changes:
- Added
lookupName/lookupKindhelpers and per-OpKindnamestables as the single mapping source of truth. - Replaced per-constructor
toString/ofString?definitions with table-driven implementations. - Updated round-trip proof commentary to reflect the new invariant enforcement mechanism.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Replace silent "?unknown?" fallback with panic! so missing table entries fail loudly (unreachable by the decide proofs). - Document why List.find? is used over HashMap: enables kernel reduction required for the round-trip decide proofs. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
force-pushed
the
tautschnig/fix-785-structured-types
branch
from
a7d028c to
50f61ed
Compare
shigoel
approved these changes
Apr 16, 2026
aqjune-aws
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each OpKind type now defines a single
names : List (OpKind × String)as the source of truth. BothtoStringandofString?are derived from this list vialookupName/lookupKindhelpers that useList.find?, which reduces in the kernel.This eliminates the sync problem: adding a new constructor without adding it to
namescauses the round-tripdecideproof to fail at compile time. There is only one place to update per new variant.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.