feat: adding terminate attribute for after-model-call-event hooks #1549
+123
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav71531
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Member
|
/strands review |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
poshinchen
requested changes
Feb 3, 2026
Contributor
poshinchen
left a comment
poshinchen
left a comment
There was a problem hiding this comment.
I see that there's conflict, could you resolve it?
pgrayy
reviewed
Feb 3, 2026
| stop_response: ModelStopResponse | None = None | ||
| exception: Exception | None = None | ||
| retry: bool = False | ||
| terminate: bool = False |
Member
There was a problem hiding this comment.
I would recommend calling this stop_loop for consistency and clarity on what specifically it is stopping. Also, would you be able to add an entry to the docstring for this field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supporting agent event loop termination via after-model-call-event hooks
Type of Change
Bug fix
[x] New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.