This repository was archived by the owner on Apr 29, 2024. It is now read-only.
Fix IsEntity sometimes returning true for previously deleted entities#508
Open
Fix IsEntity sometimes returning true for previously deleted entities#508
Conversation
ugeen4
approved these changes
Oct 14, 2023
Member
|
While it helps in some cases it's not the root cause and has to be fixed differently... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting an entity, saving the game and then loading that save game, it is possible for a newly created entity to have the same id as the old deleted entity id.
If the old entity variable is not yet overwritten, it will then return true for
IsEntity(&entity).This can be fixed by making sure the variable value is reset after calling
DeleteEntityAlso fixes PiratesAhoy/new-horizons#141