Skip to content

fix(oas): prevent duplicate null values in enum array [ISSUE-271]#272

Open
Drew-Kimberly wants to merge 3 commits intostoplightio:masterfrom
Drew-Kimberly:fix/ISSUE-271/null-value-in-enum-array
Open

fix(oas): prevent duplicate null values in enum array [ISSUE-271]#272
Drew-Kimberly wants to merge 3 commits intostoplightio:masterfrom
Drew-Kimberly:fix/ISSUE-271/null-value-in-enum-array

Conversation

@Drew-Kimberly
Copy link
Copy Markdown

Motivation and Context

null is always appended to enum array for nullable enum property. This can result in an invalid JSON schema document when null is already included as part of the enum array.
#271

Description

Checks for a null value in the enum array before appending one.

How Has This Been Tested?

Updated the OAS test fixture in f77dcf8 to demonstrate issue in resultant snapshots.

Fix can be observed in 7452a4b where invalid null values are no longer present.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@mnaumanali94 mnaumanali94 self-requested a review January 10, 2025 14:00
@Drew-Kimberly
Copy link
Copy Markdown
Author

Hi @mnaumanali94! Any chance of getting some 👀 on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant