fix(config): normalize api_endpoint to strip trailing slashes#125
Merged
ashishkurmi merged 2 commits intoMay 29, 2026
Merged
Conversation
Every backend call composes URLs as fmt.Sprintf("%s/v1/...", APIEndpoint, ...).
A user-supplied api_endpoint with a trailing slash would compose to
"//v1/..." — some gateways tolerate it, others return 403/500. Customers
hit this in production with a bootstrap.json that had a trailing slash
in the URL; removing the slash made requests start returning 200.
Normalize once at the config boundary (Load() reads, save() writes) so:
- existing config.json files with a trailing slash are forgiven without
re-running configure
- new configs written via inline flags or --from-file are sanitised before
persistence
- every URL-building callsite in telemetry/run_status/aiagents stays as-is
ashishkurmi
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every backend call composes URLs as fmt.Sprintf("%s/v1/...", APIEndpoint, ...). A user-supplied api_endpoint with a trailing slash would compose to "//v1/..." — some gateways tolerate it, others return 403/500. Customers hit this in production with a bootstrap.json that had a trailing slash in the URL; removing the slash made requests start returning 200.
Normalize once at the config boundary (Load() reads, save() writes) so:
What does this PR do?
Type of change
Testing
./stepsecurity-dev-machine-guard --verbose./stepsecurity-dev-machine-guard --json | python3 -m json.toolmake lintmake testRelated Issues