fix(mock-doc): add File global for tests#6744
Open
srikarphanikumar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Stencil's mock DOM test environment exposes browser-like globals such as
Event,Request, andResponse, but it does not exposeFile.As a result, unit tests that construct a browser
Fileobject can fail withReferenceError: File is not defined.GitHub Issue Number: #3539
What is the new behavior?
Adds a mock
Fileconstructor to Stencil's mock DOM globals.This allows Stencil unit tests to call
new File(...)in the test environment, including after rendering withnewSpecPage().The PR also adds regression coverage for:
Filebeing available on the test global andwindowFilewithname,type,lastModified, andsizeFileafter rendering a spec pageDocumentation
N/A
Does this introduce a breaking change?
Testing
npm run prettier.base -- --check src/mock-doc/file.ts src/mock-doc/global.ts src/mock-doc/index.ts src/mock-doc/test/global.spec.ts src/testing/test/functional.spec.tsxnpx eslint src/mock-doc/file.ts src/mock-doc/global.ts src/mock-doc/index.ts src/mock-doc/test/global.spec.ts src/testing/test/functional.spec.tsxnpm run tsc.prodOther information
Fixes #3539.