TypeScript Rewrite: Info command#36
Open
d4mation wants to merge 18 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d4mation
added
the
On Hold
d4mation
changed the base branch from
ENG-219/app-bootstrap
to
ENG-219/command-help
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d4mation
commented
Feb 12, 2026
Comment on lines
+108
to
+109
| console.log(formatMessage(chalk.yellow(message))); | ||
| console.log(formatMessage(chalk.yellow('='.repeat(message.length)))); |
Contributor
Author
There was a problem hiding this comment.
Noticed while comparing directly to the PHP version. This ensures we're using the exact same colors and making it feel like a very natural transition from the PHP version.
3 tasks
These cases are already covered by invalid-puprc.test.ts. Since broken config now throws before any command runs, testing it per-command is redundant.
claudiosanches
approved these changes
Feb 14, 2026
The test was only checking for substring matches, not actually verifying the output was valid JSON. Now it parses the JSON and compares against the puprc config.
jonwaldstein
added a commit
that referenced
this pull request
Jun 5, 2026
🎫 [ENG-222] ## Summary - Fix bug in `pup info` where the `.puprc` parse check was passing the filename string `'.puprc'` to `json_decode()` instead of reading the file contents first, causing it to always report a parse error even for valid `.puprc` files. Discovered while working on the TypeScript rewrite of the info command in #36. ## Test plan - [x] Run `pup info` in a project with a valid `.puprc` file — should show ✅ `.puprc - exists` - [x] Run `pup info` in a project with an invalid `.puprc` file (e.g. malformed JSON) — should show ❌ `.puprc - exists but could not be parsed: <error message>` - [x] Run `pup info` in a project with no `.puprc` file — should show ⚫ `.puprc - does not exist` [ENG-222]: https://stellarwp.atlassian.net/browse/ENG-222?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 ENG-219
Reference
Summary
infocommand that displays project configuration details.puprcsettings, version files, workflows, checks, and sync file configurationsDependencies
This PR depends on #35 (command-help) being merged first, as it uses output utility tweaks from that PR.
Test plan
npx pup infodisplays project configuration