-
Notifications
You must be signed in to change notification settings - Fork 353
Update CAP-78 #1845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CAP-78 #1845
Conversation
There was some inconsistency around `min_extension` that I've clarified. Also clarify the validation logic and justification for temporary entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR clarifies inconsistencies in the CAP-78 specification around min_extension and updates the TTL extension algorithm validation logic. The changes improve the clarity of how TTL extensions are computed and validated, particularly for temporary entries.
Changes:
- Clarified the TTL extension algorithm, simplifying the logic flow and adding explicit network limit computation
- Updated documentation to better explain the difference between
min_extensionand the oldthresholdparameter - Added justification for validation behavior differences between network limits and user-provided arguments for temporary entries
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
If in future TTL would be reimagined as time-based instead of number of ledgers, I wonder if we should do this CAP. |
I don't think so. I'm not sure yet about the feasibility of time-based TTLs, and in general it seems like a topic that will take a while to figure out and agree on. This CAP is a quick win for the existing users, and if it works well, the time-based functions could resemble this interface (or we could even make the interface polymorphic). |
There was some inconsistency around
min_extensionthat I've clarified.Also clarify the validation logic and justification for temporary entries.