Add missing runtime libraries to Docker image#2594
Conversation
|
Claude finished @fnando's task in 1m 1s —— View job Claude PR Review
SummarySmall, well-targeted fix. The image was previously broken at startup because the Correctness
Things worth thinking about (non-blocking)
VerdictLGTM. The change is minimal, accurate, and directly fixes a P0 image-startup bug. I'd merge as-is. |
There was a problem hiding this comment.
Pull request overview
Adds missing runtime shared libraries to the Docker image so the stellar CLI can start successfully. Previously the image lacked libdbus-1.so.3 (pulled in via the keyring/secure-store dependency chain enabled by the default additional-libs feature) and ca-certificates (needed for TLS to HTTPS RPC endpoints).
Changes:
- Add
ca-certificatesandlibdbus-1-3to the runtime packages installed in the Dockerfile. - Keep existing
libssl3andlibudev1installs; reorder alphabetically.
What
Install
ca-certificates,libdbus-1-3,libssl3, andlibudev1in the Docker image.Why
The image was missing runtime libraries the CLI depends on (broke on #2544), causing it to fail on startup:
ca-certificatesis also needed for TLS to remote RPC endpoints.Known limitations
N/A