Open
Conversation
fnando
requested review from
leighmcculloch and
mootz12
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
Updates soroban-cli’s config locator unit tests so Unix-specific permission assertions are only compiled/executed on Unix platforms, avoiding Windows CI failures while keeping the tests meaningful for supported semantics.
Changes:
- Gate the
locator.rstest module behind#[cfg(all(test, unix))]so it doesn’t compile on Windows. - Remove redundant per-test
#[cfg(unix)]attributes since the entire module is now Unix-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
These tests should only run on Unix.
Why
Windows tests are failing in
main.https://github.com/stellar/stellar-cli/actions/runs/22703760901/job/65826453196
Known limitations
N/A