Sign windows installer. #2357
Open
Sign windows installer. #2357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds code signing for the Windows installer using DigiCert's Software Trust Manager to eliminate the "unknown publisher" security warning during installation. The signing is conditionally applied only on releases and specific branches to conserve the limited signature quota (1000 signatures).
Changes:
- Added environment variable setup for the client certificate file path
- Configured certificate file decoding from base64-encoded secret
- Integrated DigiCert code-signing action with conditional execution
mootz12
reviewed
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Sign Windows Installer when making a new release.
Why
So we can get rid of the nasty warning on Windows. See https://github.com/stellar/ops/issues/4170 for reference.
Known limitations
Given the limited number of signatures we can issue (1000), we're only signing actual releases.