Change privacy-pools example to have one Makefile#403
Merged
leighmcculloch merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the privacy-pools example build/test workflow by removing the nested contract/Makefile and consolidating its targets into a single top-level privacy-pools/Makefile, aligning it with other examples and improving compatibility with external test runners.
Changes:
- Delete
privacy-pools/contract/Makefile. - Inline contract
build,test,fmt, andcleantargets intoprivacy-pools/Makefile. - Add an explicit build dependency for
test, and invokegroth16_verifierbuild from the top-level Makefile.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| privacy-pools/contract/Makefile | Removed nested Makefile to centralize workflows at the example root. |
| privacy-pools/Makefile | Inlines contract build/test/fmt/clean commands and triggers groth16_verifier build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jayz22
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Delete
contract/Makefileand inline its build, test, fmt, and clean commands directly into the top-levelprivacy-pools/Makefile.Why
The layout makefiles don't work very well with the testing that we run from the Soroban SDK and Stellar CLI repos. While it would be possible to make it work, it's simpler to make the privacy-pools example structure the same as the other examples in this repository.
Overall, it makes it easier for me to maintain testing with Soroban examples.
This should fix a build failure that is showing up in the stellar-cli soroban-examples builds that are being added in: