Add configurable Redis key prefixes#316
Open
jacobmstein wants to merge 4 commits intostefanprodan:masterfrom
Open
Add configurable Redis key prefixes#316jacobmstein wants to merge 4 commits intostefanprodan:masterfrom
jacobmstein wants to merge 4 commits intostefanprodan:masterfrom
Conversation
|
Actually, wouldn't it be enough to just remove the |
Author
I suppose, however I find it unreasonable to alter its current behavior as a feature. In that case, a delimiter option (default |
|
Why not merge this MR? I'm waiting for this feature. |
|
Will this ever get merged in? Would be very handy if it could. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis keys are conventionally namespaced using colons to avoid naming collisions and improve readability. Additionally, bare keys often make it difficult to view database contents from GUI clients, many of which group and filter keys by namespace.
For those reasons, this pull request introduces a
RedisRateLimitOptionsclass with aKeyPrefixproperty.