fix: add target path validation for fill disk attacks #375
+44
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A silent mount failure causes the fill to write to the sidecar's own filesystem instead of the target, which is wrong behavior that should fail fast.
Add CheckPathWritableRunc and CheckPathWritableProcess functions that verify the target directory exists and is writable before starting the fill. The runc variant creates a short-lived sidecar in the target's mount namespace; the process variant uses direct commands. Both clean up after themselves.
3 tasks
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
createBundle— previously it silently continued, causing the fill to write to the sidecar's own filesystem instead of the targetCheckPathWritableRuncandCheckPathWritableProcessfunctions that verify the target directory exists and is writable before the fill disk attack startsPreparemethod so users get an immediate, clear error instead of confusing failures during the attackTest plan
go vet ./...passesgo test ./diskfill/...passes