-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add ndarray/broadcast-scalar
#9916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
| var broadcastScalar = require( '@stdlib/ndarray/broadcast-scalar' ); | ||
| ``` | ||
|
|
||
| #### broadcastScalar( shape, value\[, options] ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@headlessNode This needs to be refactored so that we are consistent with, e.g., broadcastArray. Namely,
| #### broadcastScalar( shape, value\[, options] ) | |
| #### broadcastScalar( value, shape\[, options] ) |
This also matches the order of the "base" package
broadcastScalar( value, dtype, shape, order )It is not clear why you chose to deviate here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this is because that is the signature I used in the upstream issue. I was wrong. value should come before shape based on looking at similar packages.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves stdlib-js/metr-issue-tracker#166.
Description
This pull request:
ndarray/broadcast-scalarRelated Issues
This pull request has the following related issues:
ndarray/broadcast-scalarmetr-issue-tracker#166Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers