Skip to content

feat: add constants/float16/sqrt-three #8986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Amansingh0807 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: add constants/float16/sqrt-three #8986

Amansingh0807 wants to merge 4 commits into from
+339 −0

Conversation

@Amansingh0807
Copy link
Contributor

@Amansingh0807 Amansingh0807 commented Dec 12, 2025

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • add constants/float64/sqrt-three

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • Resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 12, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 12, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
constants/float16/sqrt-three $\color{green}51/51$
$\color{green}+0.00%$ 		$\color{green}1/1$
$\color{green}+0.00%$ 		$\color{green}0/0$
$\color{green}+0.00%$ 		$\color{green}51/51$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@Amansingh0807 Amansingh0807 force-pushed the feat-float16-sqrt-three branch from 956dfea to 83796ae Compare December 12, 2025 07:56
Neerajpathak07
Neerajpathak07 reviewed Dec 13, 2025
View reviewed changes
lib/node_modules/@stdlib/constants/float16/sqrt-three/README.md
Comment on lines 67 to 77
<section class="related">

* * *

## See Also

- <span class="package-name">[`@stdlib/constants/float16/sqrt-eps`][@stdlib/constants/float16/sqrt-eps]</span><span class="delimiter">: </span><span class="description">square root of half-precision floating-point epsilon.</span>
- <span class="package-name">[`@stdlib/constants/float32/sqrt-three`][@stdlib/constants/float32/sqrt-three]</span><span class="delimiter">: </span><span class="description">square root of `3` as a single-precision floating-point number.</span>
- <span class="package-name">[`@stdlib/constants/float64/sqrt-three`][@stdlib/constants/float64/sqrt-three]</span><span class="delimiter">: </span><span class="description">square root of 3.</span>

</section>
Copy link
Member

@Neerajpathak07 Neerajpathak07 Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<section class="related">
* * *
## See Also
- <span class="package-name">[`@stdlib/constants/float16/sqrt-eps`][@stdlib/constants/float16/sqrt-eps]</span><span class="delimiter">: </span><span class="description">square root of half-precision floating-point epsilon.</span>
- <span class="package-name">[`@stdlib/constants/float32/sqrt-three`][@stdlib/constants/float32/sqrt-three]</span><span class="delimiter">: </span><span class="description">square root of `3` as a single-precision floating-point number.</span>
- <span class="package-name">[`@stdlib/constants/float64/sqrt-three`][@stdlib/constants/float64/sqrt-three]</span><span class="delimiter">: </span><span class="description">square root of 3.</span>
</section>
<section class="related">
</section>

Copy link
Contributor Author

@Amansingh0807 Amansingh0807 Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing it !!

Neerajpathak07
Neerajpathak07 reviewed Dec 13, 2025
View reviewed changes
lib/node_modules/@stdlib/constants/float16/sqrt-three/README.md
Comment on lines 83 to 97
<section class="links">

[@stdlib/math/base/special/sqrt]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/special/sqrt

<!-- <related-links> -->

[@stdlib/constants/float16/sqrt-eps]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/constants/float16/sqrt-eps

[@stdlib/constants/float32/sqrt-three]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/constants/float32/sqrt-three

[@stdlib/constants/float64/sqrt-three]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/constants/float64/sqrt-three

<!-- </related-links> -->

</section>
Copy link
Member

@Neerajpathak07 Neerajpathak07 Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<section class="links">
[@stdlib/math/base/special/sqrt]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/special/sqrt
<!-- <related-links> -->
[@stdlib/constants/float16/sqrt-eps]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/constants/float16/sqrt-eps
[@stdlib/constants/float32/sqrt-three]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/constants/float32/sqrt-three
[@stdlib/constants/float64/sqrt-three]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/constants/float64/sqrt-three
<!-- </related-links> -->
</section>
<section class="links">
[@stdlib/math/base/special/sqrt]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/special/sqrt
</section>

Copy link
Member

@Neerajpathak07 Neerajpathak07 Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per suggested in:- https://matrix.to/#/!sZkxtbTkiuDMygJfMT:gitter.im/$eOBzW2Ivf6vPt_1jXXHQ-z36-PuN8YJwbVJxQxZ1WOg?via=gitter.im&via=matrix.org

@Amansingh0807
Copy link
Contributor Author

Amansingh0807 commented Dec 13, 2025

Thanks for the review, @Neerajpathak07!
I have implemented both suggestions - removed the auto-populated content from the related section and the related-links area. Changes pushed!

Appreciate the clarification! 🙏

@Neerajpathak07
Copy link
Member

Neerajpathak07 commented Dec 13, 2025

Just a small advice do try and avoid force pushing commits reason being when contributors pull from your work it causes merge conflicts which are pretty tedious to resolve.
If an unwanted commit was added it is viable to close the pr and create a new one.

@Amansingh0807
Copy link
Contributor Author

Amansingh0807 commented Dec 13, 2025

Thank you for the advice, @Neerajpathak07!
I completely understand - I will avoid force pushing to prevent merge conflicts. Will use revert or create a new PR if needed to undo commits.
Really appreciate you taking the time to guide me on best practices. I will keep this in mind going forward. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Neerajpathak07 Neerajpathak07 Neerajpathak07 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Amansingh0807 @stdlib-bot @Neerajpathak07