Skip to content

chore: fix JavaScript lint errors (issue #10000) #10307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Planeshifter merged 5 commits into from
Feb 17, 2026
Merged

chore: fix JavaScript lint errors (issue #10000) #10307

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfa53ee
chore: fix JavaScript lint errors (issue #10000)
Sid-V5 Feb 15, 2026
5c14181
fix: usage of `require( 'process' )` instead of global `process`
Sid-V5 Feb 16, 2026
36b195b
chore: remove extra backslashes
Planeshifter Feb 16, 2026
c26aab0
chore: minor clean-up
Planeshifter Feb 16, 2026
4a09326
Merge branch 'develop' into fix/lint-proc-undefined
Sid-V5 Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lib/node_modules/@stdlib/_tools/makie/plugins/makie-install-node-addons/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

// MODULES //

var proc = require( 'process' );
var spawn = require( 'child_process' ).spawn;


Expand Down Expand Up @@ -81,9 +82,9 @@ function stderr( data ) {
* @param {string} subpath - subdirectory path
*/
function plugin( dir, cwd, subpath ) {
var child;
var opts;
var args;
var proc;

opts = {};
opts.cwd = dir;
Expand All @@ -98,11 +99,11 @@ function plugin( dir, cwd, subpath ) {
// Target:
args.push( 'install-node-addons' );

proc = spawn( 'make', args, opts );
proc.on( 'error', onError );
proc.stdout.on( 'data', stdout );
proc.stderr.on( 'data', stderr );
proc.on( 'close', onFinish );
child = spawn( 'make', args, opts );
child.on( 'error', onError );
child.stdout.on( 'data', stdout );
child.stderr.on( 'data', stderr );
child.on( 'close', onFinish );
}


Expand Down
Loading