Skip to content

Fix lint error: unexpected empty line between require statements#10298

Closed
joelklabo wants to merge 1 commit intostdlib-js:developfrom
joelklabo:develop
Closed

Fix lint error: unexpected empty line between require statements#10298
joelklabo wants to merge 1 commit intostdlib-js:developfrom
joelklabo:develop

Conversation

@joelklabo
Copy link

@joelklabo joelklabo commented Feb 15, 2026

Summary

Fixes ESLint error in lib/node_modules/@stdlib/blas/base/dsyr2/test/test.dsyr2.js by removing the empty lines between comment section headers (// MODULES // and // FIXTURES //) and the first require statements.

Changes

  • Removed empty line after // MODULES //
  • Removed empty line after // FIXTURES //

The ESLint rule no-multiple-empty-lines was triggering because there was an empty line between the comment section headers and the first require statements.

Addresses issue #10285.

If this PR is helpful, tips appreciated via Lightning: max@klabo.world

The ESLint rule 'no-multiple-empty-lines' was triggering because
there was an empty line between the comment section headers and the
first require statements in both MODULES and FIXTURES sections.

Addresses issue stdlib-js#10285
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Feb 15, 2026
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Feb 15, 2026
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Feb 15, 2026
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not the required changes. Instead, should have removed the empty line between

 var rxnyn = require( './fixtures/row_major_xnyn.json' ); 
 
 
  var cu = require( './fixtures/column_major_u.json' );

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. and removed Needs Review A pull request which needs code review. labels Feb 15, 2026
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Feb 18, 2026
@stdlib-bot
Copy link
Contributor

Coverage Report

No coverage information available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments